Detect ROCm builds without requiring a visible GPU - #512
Open
kashif wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kashif Rasul <kashif.rasul@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #512 +/- ##
==========================================
+ Coverage 97.23% 98.20% +0.97%
==========================================
Files 10 10
Lines 217 223 +6
==========================================
+ Hits 211 219 +8
+ Misses 6 4 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.pygates the HIP extension build ontorch.cuda.is_available(), which isFalseon any machine without a visible GPU — including CI wheel builders. On a ROCm build of PyTorch that silently produces a CPU-only wheel, and it also skips theinclude_package_datawork-around that's there specifically for hipify's absolute paths.Both checks now key off
torch.version.hip, which describes the PyTorch build rather than the machine doing the building. CUDA behaviour is unchanged.Tested on ROCm 7.2 / gfx1150 with PyTorch 2.13: builds from source and the test suite passes (2771 passed, 30 skipped — the skips are all multi-GPU).