Skip to content

fix(account): display OIDC username with fallback - #229

Merged
cxymds merged 1 commit into
rustfs:mainfrom
GatewayJ:codex/oidc-account-display
Sep 11, 2026
Merged

fix(account): display OIDC username with fallback#229
cxymds merged 1 commit into
rustfs:mainfrom
GatewayJ:codex/oidc-account-display

Conversation

@GatewayJ

Copy link
Copy Markdown
Member

Pull Request

Description

Display the verified OIDC username on the account page and user menu. When the configured username claim is missing or blank, fall back to email and then to the existing access key/account name.

The user menu reuses its existing /accountinfo response, so this change adds no request or competing identity source. Companion backend change: rustfs/rustfs#7654.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed
pnpm install --frozen-lockfile
pnpm type-check
pnpm lint
pnpm format:check
pnpm test:run
pnpm build

All 572 unit/source tests passed. Production builds for the upstream base and this commit were loaded with the same mocked authenticated OIDC response at a 1440 × 1000 viewport. The screenshots cover the loaded account page and the open user menu.

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added, or they are justified

Related Issues

Related to rustfs/rustfs#7646.

Screenshots (if applicable)

Before

Before: account surfaces show the OIDC virtual parent

After

After: account surfaces show the OIDC username

Additional Notes

  • The display-only resolution order is usernameemailaccess_key/account_name.
  • Older RustFS responses remain supported because the existing account identifier is retained as the final fallback.
  • Authentication and authorization identities are unchanged.

Prefer the verified OIDC username in account surfaces, fall back to email when it is unavailable, and retain the existing access key display for older servers and non-OIDC sessions.\n\nReuse the existing accountinfo request for the user menu and cover the fallback order with regression tests.
@GatewayJ

Copy link
Copy Markdown
Member Author

@codex

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T05:00:21.902242Z 152e407 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 152e407b53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@GatewayJ
GatewayJ requested a review from cxymds September 11, 2026 05:12
@cxymds
cxymds merged commit d11dd0f into rustfs:main Sep 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants