psm: add tvOS to Apple platform checks in assembly files#142
Open
TevJ wants to merge 1 commit intorust-lang:masterfrom
Open
psm: add tvOS to Apple platform checks in assembly files#142TevJ wants to merge 1 commit intorust-lang:masterfrom
TevJ wants to merge 1 commit intorust-lang:masterfrom
Conversation
The Mach-O symbol naming convention (underscore-prefixed symbols) applies to all Apple platforms, but the preprocessor guards in the assembly files only checked for darwin, macos, and ios. This adds tvos so that psm produces correct symbol names when targeting aarch64-apple-tvos and similar tvOS targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
CFG_TARGET_OS_tvosto the Apple platform preprocessor guards in psm's assembly files.tvOS uses the same Mach-O underscore-prefixed symbol naming convention as macOS and iOS, but the assembly guards don't currently include it. This caused incorrect symbol names when compiling for targets like aarch64-apple-tvos.
We build an SDK which uses psm and runs on tvOS. I have a local patch currently but it would be good to upstream it, we've had no issues running our build on tvOS devices.
I've applied the update to all four architecture-specific assembly files (aarch_aapcs64.s, x86_64.s, x86.s, arm_aapcs.s) for consistency, though in practice only aarch_aapcs64.s is relevant for tvOS targets.
Cheers!