fix: properly wrap long impl trait function parameters#6798
Merged
ytmimi merged 1 commit intorust-lang:mainfrom Feb 12, 2026
Merged
fix: properly wrap long impl trait function parameters#6798ytmimi merged 1 commit intorust-lang:mainfrom
impl trait function parameters#6798ytmimi merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
the
S-waiting-on-review
ytmimi
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Show that the line doesn't wrap for style-edition=2024
ytmimi
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Show that the line properly wraps for style-edition=2027
jieyouxu
approved these changes
Feb 12, 2026
src/types.rs
Outdated
Comment on lines
1022
to
1023
| // 5 = 'impl ` | ||
| let shape = shape.offset_left(5, self.span())?; |
Member
There was a problem hiding this comment.
Remark: I suppose one could also write
"impl ".chars().count()"impl ".len() // same as above due to only-ASCIIBut comment works too :D
Contributor
Author
There was a problem hiding this comment.
We've typically left comments in the code but I don't mind changing this to "impl ".len().
jieyouxu
added
the
F-requires-next-style-edition
Before we weren't taking the length of `impl ` into account so the trait thought it had more room than it actually did to format itself on a single line.
rustbot
added
release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6381
Before we weren't taking the length of
implinto account so the trait thought it had more room than it actually did to format itself on a single line.