Skip to content

fail loudly on unsized by-ref invariants #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjorn3 merged 2 commits into from
Apr 16, 2026
+10 −2
Merged

fail loudly on unsized by-ref invariants #1644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a8f3af
handle unsized by-ref values
0xmuon Apr 14, 2026
2237da2
fail loudly on unsized by-ref invariants
0xmuon Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/value_and_place.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,9 @@ impl<'tcx> CValue<'tcx> {
let (field_ptr, field_layout) = codegen_field(fx, ptr, None, layout, field);
CValue::by_ref(field_ptr, field_layout)
}
CValueInner::ByRef(_, Some(_)) => todo!(),
CValueInner::ByRef(_, Some(_)) => {
bug!("value_field for unsized by-ref value not supported")
}
Comment thread
bjorn3 marked this conversation as resolved.
}
}

Expand Down Expand Up @@ -655,7 +657,13 @@ impl<'tcx> CPlace<'tcx> {
flags,
);
}
CValueInner::ByRef(_, Some(_)) => todo!(),
CValueInner::ByRef(_from_ptr, Some(_extra)) => {
bug!(
"write_cvalue for unsized by-ref value not allowed: dst={:?} src={:?}",
dst_layout.ty,
from.layout().ty
);
}
}
}
}
Expand Down
Loading