Compute job time in post-merge-report from the actual GitHub duration - #161235
Merged
Conversation
rustbot
added
A-CI
jieyouxu
reviewed
Aug 17, 2026
Member
Author
|
Rofl. I wrote the function in a way that it only compiles under Polonius. |
Kobzol
force-pushed
the
citool-actual-job-time
branch
from
August 17, 2026 14:38
a870429 to
4314166
Compare
This comment has been minimized.
This comment has been minimized.
Kobzol
force-pushed
the
citool-actual-job-time
branch
from
August 18, 2026 06:32
4314166 to
5fbbb20
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
jieyouxu
approved these changes
Aug 18, 2026
Comment on lines
+241
to
+244
| let duration_before = | ||
| job_info_resolver.get_job_duration(job, parent).unwrap_or(Duration::ZERO); | ||
| let duration_after = | ||
| job_info_resolver.get_job_duration(job, &metrics.current).unwrap_or(Duration::ZERO); |
Member
There was a problem hiding this comment.
NB: I wonder if we can indicate which of the {github, bootstrap} job duration source is actually being reported, but I think at least pairing the start/end times from the same source is sensible.
Member
Author
There was a problem hiding this comment.
Since we talk about the duration of CI jobs, I think that reportin the GitHub job duration is obvious. We just didn't do the obvious thing previously 😆
Member
Author
There was a problem hiding this comment.
There are some benefits to reporting pure bootstrap time though, as it doesn't take into account Docker builds and other stuff that can be noisy. But the disadvantage is that it doesn't take into account Docker builds and... :)
Member
Author
|
@bors r=jieyouxu rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 18, 2026
…uwer Rollup of 11 pull requests Successful merges: - #161024 (resolving cyclic glob vis-max) - #161231 (passes: `rustc_scalable_vector` fields are not dead) - #161238 (remove scalar size mismatch interpreter error, make it an ICE instead) - #160345 (Resolver: add `checked` methods for `Cm(Ref)Cell`) - #161129 (Avoid ICE when recovering parenthesized type parameters) - #161235 (Compute job time in post-merge-report from the actual GitHub duration) - #161239 (Fix `#[repr(transparent)]` wrapper types not working with `Complex<T>`) - #161244 (Add regression test for indexing an unsized static without a body) - #161257 (Ignore target feature test when LLVM fails to compile minicore) - #161258 (perf: return early from in_external_macro for root contexts) - #161278 (Add regression test for normalization failure on erased closure in async block)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 18, 2026
Rollup merge of #161235 - Kobzol:citool-actual-job-time, r=jieyouxu Compute job time in post-merge-report from the actual GitHub duration Up until now, the post-merge report analysis showed job durations computed from the sum of executed bootstrap steps. But this is quite confusing, because it does not correspond to the actual times we see on GitHub. I got quite worried recently about some durations, until I realized that I'm looking at something different than I thought I was. r? jieyouxu
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Aug 19, 2026
…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#161024 (resolving cyclic glob vis-max) - rust-lang/rust#161231 (passes: `rustc_scalable_vector` fields are not dead) - rust-lang/rust#161238 (remove scalar size mismatch interpreter error, make it an ICE instead) - rust-lang/rust#160345 (Resolver: add `checked` methods for `Cm(Ref)Cell`) - rust-lang/rust#161129 (Avoid ICE when recovering parenthesized type parameters) - rust-lang/rust#161235 (Compute job time in post-merge-report from the actual GitHub duration) - rust-lang/rust#161239 (Fix `#[repr(transparent)]` wrapper types not working with `Complex<T>`) - rust-lang/rust#161244 (Add regression test for indexing an unsized static without a body) - rust-lang/rust#161257 (Ignore target feature test when LLVM fails to compile minicore) - rust-lang/rust#161258 (perf: return early from in_external_macro for root contexts) - rust-lang/rust#161278 (Add regression test for normalization failure on erased closure in async block)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up until now, the post-merge report analysis showed job durations computed from the sum of executed bootstrap steps. But this is quite confusing, because it does not correspond to the actual times we see on GitHub. I got quite worried recently about some durations, until I realized that I'm looking at something different than I thought I was.
r? jieyouxu