Assorted allocator nitpicks by nia-e · Pull Request #161115 · rust-lang/rust

nia-e · 2026-08-14T23:22:13Z

Small things that got missed in #157428, doc language cleanup for allocator, and a rename that closes #158344. cc @rust-lang/wg-allocators. pending libs bikeshed decision on the naming of into_raw_parts_with_alloc

r? clarfonthey

clarfonthey · 2026-08-14T23:45:04Z

r=me minus const bound note. (either remove unused const bound on both, or constify both)

clarfonthey · 2026-08-14T23:54:29Z

New changes look good too, but will hold merge in case you have anything else to add. (r=me)

bushrat011899

One very minor nit, otherwise looks good to me!

View changes since this review

nia-e · 2026-08-18T18:27:45Z

@bors r=clarfonthey rollup

rust-bors · 2026-08-18T18:27:48Z

📌 Commit be759d2 has been approved by clarfonthey

It is now in the queue for this repository.

nia-e · 2026-08-18T18:40:53Z

forgot to squash, oopers

@bors r-

rust-bors · 2026-08-18T18:40:58Z

This pull request was unapproved.

View changes since this unapproval

nia-e · 2026-08-18T18:41:12Z

@bors squash

rust-bors · 2026-08-18T18:41:15Z

🚧 Squashing... this can take a few minutes.

rust-bors · 2026-08-18T18:42:16Z

❗ Failed to push the squashed commit to nia-e/rust:allocator-nitpicks: Push timeouted

ref mut const unstable matching ref vec, vecdeque: rename alloc to allocator staticallocator on ref mut as well wording will be the death of me words order words random word words random good eeeeeeeeeeeee oh yeah these need the bound

maxdexh · 2026-08-18T18:50:08Z

I can see someone wants to get this merged 😂

nia-e · 2026-08-18T18:51:44Z

i also added the AllocatorClone bound to the conversion from Box to {Ar,R}c (mostly to prevent anyone from doing it on stable w/ a custom allocator, even though it's sound without since we gate Clone for {Ar,R}c)

maxdexh · 2026-08-18T18:57:44Z

Probably don't do that, you can write that downstream for Box<LocalType, MyAlloc>. (although i guess only for Rc<T, Global>?)

nia-e · 2026-08-18T19:00:17Z

yep. though im okay keeping it so you can create an Rc with a custom allocator since it wouldn't be clonable

maxdexh · 2026-08-18T19:02:28Z

I don't think you can call that impl for allocators other than global? I'll do more testing around fundamental in general before stabilization because I feel like there's some weird stuff here

nia-e · 2026-08-18T19:04:56Z

we want to eventually offer From<Box<T, A: Allocator>> for Rc<T, A>. i guess the right call here is to just stabilise that and it's fine bc you can never clone that rc. i'll just change it back to that

maxdexh · 2026-08-18T19:07:23Z

If you can call that, that's already problematic because we also want to change the Send and Sync impl on Arc

maxdexh · 2026-08-18T19:09:01Z

~~There will have to be another PR with API stuff anyway, since some of the impls need to be generalized so that users don't write them themselves.~~ maybe not

clarfonthey · 2026-08-18T19:39:37Z

-/// allocated memory.
+/// `Allocator` is mostly designed to be implemented on ZSTs, references, or smart pointers,
+/// but can also be implemented directly on the underlying memory-owning type so long as it
+/// upholds the necessary guarantees. In general, an allocator for `MyAlloc([u8; N])` cannot be


Suggested change

/// upholds the necessary guarantees. In general, an allocator for `MyAlloc([u8; N])` cannot be

/// upholds the necessary guarantees. In general, an allocator `MyAlloc([u8; N])` cannot be

View changes since the review

Actually, maybe it's better to just say you can't have an allocator like this realistically and say "it needs to be more complicated than e.g. MyAlloc([u8; N])

nia-e · 2026-08-18T19:47:24Z

ready on my end, feel free to r+ this once you've reviewed clar ^

clarfonthey · 2026-08-18T19:48:57Z

@bors r+ rollup

Looked through all remaining comments, everything looks to be resolved.

rust-bors · 2026-08-18T19:49:05Z

📌 Commit 7d40fdb has been approved by clarfonthey

It is now in the queue for this repository.

…nthey Assorted allocator nitpicks Small things that got missed in rust-lang#157428, doc language cleanup for allocator, and a rename that closes rust-lang#158344. cc @rust-lang/wg-allocators. pending libs bikeshed decision on the naming of `into_raw_parts_with_alloc` r? clarfonthey

Rollup of 18 pull requests Successful merges: - #154210 (fix: fix the capture behavior of `if let` in closures) - #156176 (Initial implementation of `FnPtr` trait) - #160767 (Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling) - #161297 (std: use UNIX's `Instant` and `SystemTime` on Hermit) - #160489 (Adding diagnostic item markers for multiple fs functions and structs) - #160643 (Require windowed (and exception) for Xtensa ABI) - #161088 (suppress projection errors already covered by a trait error) - #161114 (Remove fields from TypeKind: Struct, Enum, Union and Tuple) - #161115 (Assorted allocator nitpicks) - #161220 (bootstrap: Allow `./x fix --allow-dirty`) - #161296 (Enable overflow checks in `rustc_thread_pool`) - #161298 (remove rustc_error_messages dependency) - #161304 (Rename test so it matches the issue) - #161309 (`allow(non_camel_case_types)` in `minicore.rs`) - #161315 (Relax codgen test variable regex) - #161318 (Doc: clarify how `Read::bytes` handling Interrupted errors) - #161321 (Update books) - #161335 ([compiletest] Use the correct rustc lib directory for query_rustc_output)

Rollup merge of #161115 - nia-e:allocator-nitpicks, r=clarfonthey Assorted allocator nitpicks Small things that got missed in #157428, doc language cleanup for allocator, and a rename that closes #158344. cc @rust-lang/wg-allocators. pending libs bikeshed decision on the naming of `into_raw_parts_with_alloc` r? clarfonthey

rustbot assigned clarfonthey Aug 14, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 14, 2026

nia-e commented Aug 14, 2026

View reviewed changes

Comment thread library/core/src/alloc/mod.rs

Comment thread library/alloc/src/vec/mod.rs

Comment thread library/core/src/alloc/mod.rs

This comment has been minimized.

Sign in to view

nia-e commented Aug 15, 2026

View reviewed changes

Comment thread library/core/src/alloc/mod.rs Outdated

theemathas reviewed Aug 15, 2026

View reviewed changes

Comment thread library/core/src/alloc/mod.rs Outdated

Comment thread library/core/src/alloc/mod.rs Outdated

Comment thread library/core/src/alloc/mod.rs Outdated

This comment has been minimized.

Sign in to view

N1ark reviewed Aug 15, 2026

View reviewed changes

Comment thread library/core/src/alloc/mod.rs

maxdexh reviewed Aug 16, 2026

View reviewed changes

Comment thread library/core/src/alloc/mod.rs Outdated

maxdexh reviewed Aug 16, 2026

View reviewed changes

Comment thread library/core/src/alloc/mod.rs

bushrat011899 approved these changes Aug 17, 2026

View reviewed changes

Comment thread library/core/src/alloc/mod.rs Outdated

juntyr reviewed Aug 18, 2026

View reviewed changes

Comment thread library/core/src/alloc/mod.rs

maxdexh reviewed Aug 18, 2026

View reviewed changes

Comment thread library/core/src/alloc/mod.rs Outdated

maxdexh reviewed Aug 18, 2026

View reviewed changes

Comment thread library/core/src/alloc/mod.rs Outdated

maxdexh reviewed Aug 18, 2026

View reviewed changes

Comment thread library/core/src/alloc/mod.rs

nia-e mentioned this pull request Aug 18, 2026

alloc: stabilise Allocator #156882

Open

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2026

allocator: wording & grammar nitpicks

1724501

ref mut const unstable matching ref vec, vecdeque: rename alloc to allocator staticallocator on ref mut as well wording will be the death of me words order words random word words random good eeeeeeeeeeeee oh yeah these need the bound

nia-e force-pushed the allocator-nitpicks branch from cc3398f to 1724501 Compare August 18, 2026 18:48

okay max sure

c132f36

undo rc and arc thing

2ee54ff

nia-e added 2 commits August 18, 2026 21:16

tighten send so bad rc can't be used

4f2bbfd

this too

31d172e

clarfonthey reviewed Aug 18, 2026

View reviewed changes

there u go

7d40fdb

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2026

JonathanBrouwer mentioned this pull request Aug 18, 2026

Rollup of 13 pull requests #161322

Closed

This was referenced Aug 19, 2026

Rollup of 19 pull requests #161337

Closed

Rollup of 18 pull requests #161338

Merged

rust-bors Bot merged commit 63f0cfc into rust-lang:main Aug 19, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Aug 19, 2026

	/// upholds the necessary guarantees. In general, an allocator for `MyAlloc([u8; N])` cannot be
	/// upholds the necessary guarantees. In general, an allocator `MyAlloc([u8; N])` cannot be

Uh oh!

Uh oh!

Conversation

nia-e commented Aug 14, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clarfonthey commented Aug 14, 2026

Uh oh!

clarfonthey commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

bushrat011899 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nia-e commented Aug 18, 2026

Uh oh!

rust-bors Bot commented Aug 18, 2026

Uh oh!

nia-e commented Aug 18, 2026

Uh oh!

rust-bors Bot commented Aug 18, 2026

Uh oh!

nia-e commented Aug 18, 2026

Uh oh!

rust-bors Bot commented Aug 18, 2026

Uh oh!

rust-bors Bot commented Aug 18, 2026

Uh oh!

maxdexh commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nia-e commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxdexh commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nia-e commented Aug 18, 2026

Uh oh!

maxdexh commented Aug 18, 2026

Uh oh!

nia-e commented Aug 18, 2026

Uh oh!

maxdexh commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxdexh commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clarfonthey Aug 18, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

clarfonthey Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

nia-e Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

nia-e commented Aug 18, 2026

Uh oh!

clarfonthey commented Aug 18, 2026

nia-e commented Aug 14, 2026 •

edited by rustbot

Loading

clarfonthey commented Aug 14, 2026 •

edited

Loading

bushrat011899 left a comment •

edited by rustbot

Loading

maxdexh commented Aug 18, 2026 •

edited

Loading

nia-e commented Aug 18, 2026 •

edited

Loading

maxdexh commented Aug 18, 2026 •

edited

Loading

maxdexh commented Aug 18, 2026 •

edited

Loading

maxdexh commented Aug 18, 2026 •

edited

Loading

clarfonthey Aug 18, 2026 •

edited by rustbot

Loading