Add armv7-unknown-linux-musleabihf host tools to CI

[alex]

View all comments

Related to rust-lang/rustup#3398

try-job: dist-armv7-linux-musl
try-job: dist-various-1

[rustbot]

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[alex]

I know there's a command to run a particular CI runner, but a) I don't know the syntax, b) not sure if I have permissions to do it?

[workingjubilee]

Let's make sure you can do that:

@bors2 delegate=try

@alex Generally you edit your PR desc so it has

try-job: job

And then @ bors2 try

See

rust/src/ci/citool/src/main.rs

Lines 55 to 63 in e314b97

	/// Tries to parse patterns of CI jobs that should be executed
	/// from the commit message of the passed GitHub context
	///
	/// They can be specified in the form of
	/// try-job: <job-pattern>
	/// or
	/// try-job: `<job-pattern>`
	/// (to avoid GitHub rendering the glob patterns as Markdown)
	fn get_try_job_patterns(&self) -> Vec<String> {

[rust-bors]

@alex can now perform try builds on this pull request

[alex]

@bors2 try

[rust-bors]

⌛ Trying commit 0f7f1ba with merge f285d4c…

To cancel the try build, run the command @bors2 try cancel.

[rust-bors]

💔 Test failed

• CI ❌

[alex]

@bors2 try

[rust-bors]

⌛ Trying commit 9307946 with merge cbfa86a…

To cancel the try build, run the command @bors2 try cancel.

[rust-bors]

☀️ Try build successful (CI)
Build commit: cbfa86a (cbfa86ae9d01dbbaf62d3c0f479a7fd7cfda2c14, parent: 68ac5abb067806a88464ddbfbd3c7eec877b488d)

[Mark-Simulacrum]

I think this needs to follow the process for promoting to tier 2 with host tools - https://doc.rust-lang.org/beta/rustc/target-tier-policy.html#tier-2-with-host-tools, are you preparing that elsewhere? Config here seems OK, though it should probably be removing the tier 2 build from the dist-various builder?

@rustbot author

[alex]

Sure, I'm happy to fill out an MCP for this -- is there by chance a previous one you know of that I can use as a reference on the format/level of detail that's expected?

[alex]

@bors2 try

[rust-bors]

⌛ Trying commit af713a3 with merge f3f4c61…

To cancel the try build, run the command @bors2 try cancel.

[Mark-Simulacrum]

You'd want to find the previous (if one exists) proposal for this target and copy/paste the target policy, filling out any item with details since the last uplift (to tier 2, if that one exists).

rust-lang/compiler-team#864 is a tier 2 uplift but is broadly the right shape.

[rust-bors]

💔 Test failed

• CI ❌

[alex]

@bors2 try

[rust-bors]

⌛ Trying commit af713a3 with merge 1bf1316…

To cancel the try build, run the command @bors2 try cancel.

[alex]

Proposed at rust-lang/compiler-team#888, thanks for the guidance.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 1bf1316 (1bf13165b06393e0b1c3b1d3beca8520afc7ba31, parent: a30f1783fe136d92545423dd30b12eb619973cdb)

[rust-bors]

☔ The latest upstream changes (presumably #154008) made this pull request unmergeable. Please resolve the merge conflicts.