Enable f16 tests on platforms that were missing conversion symbols#129385
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 28, 2024
Merged
Enable f16 tests on platforms that were missing conversion symbols#129385bors merged 1 commit intorust-lang:masterfrom
f16 tests on platforms that were missing conversion symbols#129385bors merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only requirement for
f16support, aside from LLVM not crashing and no ABI issues, is that symbols to convert to and fromf32are available. Since the update to compiler-builtins in #125016, we now provide these on all platforms.This also enables
f16math since there are no further requirements.Still excluded are platforms for which LLVM emits infinitely-recursing code.
try-job: arm-android
try-job: test-various
try-job: x86_64-fuchsia