Rework non_local_definitions lint to only use a syntactic heuristic#127117
Merged
bors merged 5 commits intorust-lang:masterfrom Sep 24, 2024
Merged
Rework non_local_definitions lint to only use a syntactic heuristic#127117bors merged 5 commits intorust-lang:masterfrom
non_local_definitions lint to only use a syntactic heuristic#127117bors merged 5 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks the
non_local_definitionslint to only use a syntactic heuristic, i.e. not use a type-system logic for whenever animplis local or not.Instead the new logic wanted by T-lang in #126768 (comment), which is to consider every paths in
SelfandTraitand to no longer use the type-system inference trick.@rustbot labels +L-non_local_definitions
Fixes #126768