Skip to content

replace box_patterns usage with deref_patterns - #17008

Merged
blyxyas merged 2 commits into
rust-lang:masterfrom
cyrgani:unbox
Aug 13, 2026
Merged

replace box_patterns usage with deref_patterns#17008
blyxyas merged 2 commits into
rust-lang:masterfrom
cyrgani:unbox

Conversation

@cyrgani

@cyrgani cyrgani commented May 13, 2026

Copy link
Copy Markdown
Contributor

Part of rust-lang/rust#156110.

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 13, 2026
@rustbot

rustbot commented May 13, 2026

Copy link
Copy Markdown
Collaborator

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, llogiq, samueltardieu

@rustbot

This comment has been minimized.

@blyxyas

blyxyas commented Aug 13, 2026

Copy link
Copy Markdown
Member

r? @blyxyas

@rustbot rustbot assigned blyxyas and unassigned llogiq Aug 13, 2026

@blyxyas blyxyas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ฅ( ᵕ ω ᵕ )ฅ Looking good, just have a nit/question

View changes since this review

Comment thread clippy_lints/src/unnested_or_patterns.rs

@blyxyas blyxyas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this issue! ❤️ ฅ•ω•ฅ

View changes since this review

@blyxyas
blyxyas added this pull request to the merge queue Aug 13, 2026
Merged via the queue into rust-lang:master with commit d2c4d15 Aug 13, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 13, 2026
@cyrgani
cyrgani deleted the unbox branch August 13, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants