Skip to content

fix(implements_trait_unique_with_infcx): only forbid the self type from being an error type #22617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChayimFriedman2 merged 1 commit into from
Jun 19, 2026
Merged

fix(implements_trait_unique_with_infcx): only forbid the self type from being an error type #22617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/hir-ty/src/traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ use hir_expand::name::Name;
use intern::sym;
use rustc_type_ir::{
TypeVisitableExt, TypingMode,
inherent::{BoundExistentialPredicates, GenericArg as _, IntoKind, Ty as _},
inherent::{BoundExistentialPredicates, IntoKind, Ty as _},
};

use crate::{
Expand Down Expand Up @@ -153,10 +153,10 @@ pub fn implements_trait_unique_with_infcx<'db>(
let infcx = interner.infer_ctxt().build(TypingMode::non_body_analysis());

let args = create_args(&infcx);
if args.iter().filter_map(|it| it.as_type()).any(|ty| ty.is_ty_error()) {
let trait_ref = rustc_type_ir::TraitRef::new_from_args(interner, trait_.into(), args);
if trait_ref.self_ty().is_ty_error() {
return false;
}
let trait_ref = rustc_type_ir::TraitRef::new_from_args(interner, trait_.into(), args);

let obligation = Obligation::new(interner, ObligationCause::dummy(), env.param_env, trait_ref);
infcx.predicate_must_hold_modulo_regions(&obligation)
Expand Down