Migrate convert_closure_to_fn assist to SyntaxEditor#21790
Open
asuto15 wants to merge 1 commit intorust-lang:masterfrom
Open
Migrate convert_closure_to_fn assist to SyntaxEditor#21790asuto15 wants to merge 1 commit intorust-lang:masterfrom
convert_closure_to_fn assist to SyntaxEditor#21790asuto15 wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
asuto15
changed the title
convert_closure_to_fn assists to SyntaxEditorconvert_closure_to_fn assist to SyntaxEditor
A4-Tacks
reviewed
Mar 21, 2026
| Vec::new(), | ||
| ); | ||
| body_prefix_ranges_to_delete | ||
| .extend(token_with_following_whitespace_ranges(&body, gen_token)); |
Member
There was a problem hiding this comment.
Why storage TextRange instead of SyntaxElement?
TextRange operations can easily introduce potential bugs
Suggest calculating TextRange during editing to reduce changes to the original code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #15710 and #18285
This PR removes mutable tree editing from
convert_closure_to_fnby collecting capture usages from the original closure body and replaying block-modifier cleanup and capture replacements on a cloned body subtree.