Skip to content

linux: relocate PIDFD definitions to src/new#4981

Open
raushan728 wants to merge 1 commit intorust-lang:mainfrom
raushan728:add-statx-and-cachestat
Open

linux: relocate PIDFD definitions to src/new#4981
raushan728 wants to merge 1 commit intorust-lang:mainfrom
raushan728:add-statx-and-cachestat

Conversation

@raushan728
Copy link

@raushan728 raushan728 commented Feb 16, 2026

Relocated the pidfd module to src/new/linux_uapi/linux/pidfd.rs to match the modern directory structure.

  • Registered pidfd under the linux target in src/new.

  • Updated libc-test to properly skip PIDFD_ constants on older kernels.

@raushan728 raushan728 force-pushed the add-statx-and-cachestat branch 2 times, most recently from 3afac89 to 6e0883d Compare February 16, 2026 18:25
@rustbot

This comment has been minimized.

@raushan728 raushan728 force-pushed the add-statx-and-cachestat branch 2 times, most recently from 082d107 to a8c9f9a Compare February 16, 2026 18:48
@rustbot

This comment has been minimized.

@raushan728 raushan728 force-pushed the add-statx-and-cachestat branch from a8c9f9a to b8c947c Compare February 16, 2026 18:57
@raushan728 raushan728 changed the title linux: add statx and cachestat linux: add PIDFD_NONBLOCK and sort pidfd constants Feb 16, 2026
@tgross35
Copy link
Contributor

Adding the constant is fine, though you should do = O_NONBLOCK like it is in source rather than redefining.

If you are interested in doing reorganization, though, instead of sorting could you just move all the relevant pidfd bits to a new file src/new/linux_uapi/linux/pidfd.h? Making sure things match up with https://github.com/torvalds/linux/blob/0f2acd3148e0ef42bdacbd477f90e8533f96b2ac/include/uapi/linux/pidfd.h.

@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@raushan728 raushan728 force-pushed the add-statx-and-cachestat branch 6 times, most recently from a4d1bd1 to 4144e63 Compare February 17, 2026 07:10
@raushan728 raushan728 force-pushed the add-statx-and-cachestat branch from 4144e63 to 7d6a316 Compare February 17, 2026 07:39
@raushan728 raushan728 force-pushed the add-statx-and-cachestat branch from 7d6a316 to e6203ea Compare February 17, 2026 07:44
@raushan728 raushan728 changed the title linux: add PIDFD_NONBLOCK and sort pidfd constants linux: relocate PIDFD definitions to src/new Feb 17, 2026
@raushan728
Copy link
Author

@tgross35 done i have relocated everything to src/new and addressed all your feedback. thanks for the guidance. plz take a look

@raushan728 raushan728 requested a review from tgross35 February 18, 2026 10:48
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file structure looks correct to me now, but it looks like there are still some changes that need to be dropped here

View changes since this review

@rustbot
Copy link
Collaborator

rustbot commented Mar 2, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants