Conversation
rusq
marked this pull request as ready for review
July 9, 2026 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the LX-D02 print-job state machine to use
github.com/looplab/fsmand adds job-scoped routing for FSM side effects. Internal print events now dispatch directly to the owning print job instead of sharing the notification queue, while printer notifications remain best-effort and non-blocking.Why
The previous switch-based FSM mixed internal packet-stream completion with printer
5a06completion and used shared channels that could deadlock or receive stale events. Follow-up review also found that required internal events could be dropped when the notification queue was full, and stale goroutines from a canceled print could affect the next print.Changes
printJobowner for the FSM, notification queue, completion channel, cancellation, and packet-stream cancellation.eventPacketsSentfrom printereventNotificationFinished.Validation
go test ./...go test -race ./...