Repository navigation
Encoded storage operations - #4
Merged
Merged
Conversation
The generator reads the SDK's new EncodedStorage interface: the protocol gains DequeueBatchEncoded, AckSuccessEncoded and SignalActivityEncoded, and the client implements them. storaged's generated dispatch serves them, with the long-poll cap on the encoded claim and bounds on encoding names. Builds against runnerq-go ae06f34 until #67 merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol side of alob-mtc/runnerq-go#67, which adds payload/result encodings and failure details to the storage contract so TypeScript workers can use hosted storage with their own semantics.
tools/generate.pyreads the SDK's newEncodedStorageinterface. The protocol gainsDequeueBatchEncoded,AckSuccessEncodedandSignalActivityEncoded, and the generated client implements them.storageddispatch (generated into runnerq-cloud):DequeueBatch;QueuedActivity.Serialization,ActivityResult.SerializationandFailureKind.Detailscome through the protocol's argument types as they are. They'reomitempty, so Go workers send the same JSON as before.Checked: the adapter's tests pass. The
storagedside is runnerq/runnerq-cloud (thefeat/encoded-storagePR), where a new test drives the operations through this client.