Repository navigation
ci(docs): read the Cloudflare Pages token from Secret Manager with GitHub OIDC (RB-7896) - #365
Merged
Merged
Conversation
…tHub OIDC (RB-7896)
runbear-bot
approved these changes
Nov 17, 2026
runbear-bot
left a comment
Collaborator
There was a problem hiding this comment.
Bobb's bot(Totoro) Review
Conclusion: ready-with-notes
- 변경된 워크플로는
mainpush에서만 Google OIDC 인증·Secret Manager 토큰 조회·Cloudflare Pages 배포를 수행하고, PR/다른 브랜치 실행은 빌드로 제한합니다. contents: read와id-token: write권한, Secret Manager 출력 참조, 기존CLOUDFLARE_ACCOUNT_ID시크릿 사용 계약을 diff 기준으로 확인했으며, 변경 라인에 해당하는 merge-blocking 결함은 없습니다.- Terraform 권한 PR 적용 전에는 실제 배포를 검증할 수 없습니다. 이 clean checkout에는 로컬 패키지 도구/의존성이 없어 패키지 테스트는 실행하지 않았습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇을
docs 배포가 Cloudflare 토큰을 저장소 시크릿 대신 Secret Manager(
beardrive-docs-cloudflare-api-token)에서 GitHub OIDC로 읽습니다. 인증·토큰 읽기·배포 단계는main에서만 돕니다.왜
토큰을 바꿀 때마다 사람이 저장소 시크릿에 복사하지 않도록 합니다 (RB-7896). 읽기 권한은
main실행에만 있어서 PR이나 다른 브랜치는 토큰을 읽지 못합니다.리뷰어가 정할 것
github.event_name != 'pull_request'에서github.ref == 'refs/heads/main'으로 바뀝니다. 다른 브랜치에서 수동 실행하면 지금은--branch=main으로 배포되지만, 이제는 빌드만 합니다(OIDC 권한도main에만 있음).적용 후 확인
main에서 docs 배포가 돕니다. 성공을 확인한 뒤 저장소 시크릿CLOUDFLARE_API_TOKEN을 지웁니다.Agent notes
actionlintpassed. Samegoogle-github-actions/auth@v3+ provider path as runbear-io/searchd deploy.yml, withoutservice_account(direct WIF).