Repository navigation
Conversation
A finding stood until its file changed again, so a rule fix never reached findings already on disk: slugs flagged by the pre-v0.18.1 OpenAI rule kept warning on every prompt. Record the rule set's fingerprint beside the findings and re-scan only the flagged paths once when it differs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A sync-scan finding stands until its file changes again. So a rule fix never reaches findings already on disk: paths flagged by the old OpenAI rule (URL/filename slugs such as
help-desk-tools, fixed in 7380a79) keep showing inbdrive statusand the agent hook on every prompt, even on binaries whose rules no longer match them.Fix
secrets.Fingerprint()hashes the rule ids and patterns.secrets-rules-<mount>.json), as a sibling file so existing records still load.Tests
TestSecretRecordRejudgedWhenRulesChange: a stale slug finding and a missing path are cleared, a real key is kept, and revalidation does not repeat without a rule change.go test ./internal/syncer ./internal/store ./internal/secrets ./internal/webapppasses.🤖 Generated with Claude Code