Add nohup support for MongoDB 8.2+ without --fork flag#916
Open
bruno580 wants to merge 2 commits into
Open
Conversation
|
Please please merge this one! 🙏 |
There was a problem hiding this comment.
Pull request overview
Updates mlaunch process startup command construction to avoid MongoDB 8.2+ failures on macOS caused by --fork by switching to a nohup-based background launch strategy.
Changes:
- Conditionally replace
--forkwithnohup ... &formongodwhen running MongoDB 8.2+ on non-Windows platforms. - Conditionally replace
--forkwithnohup ... &formongoswhen running MongoDB 8.2+ on non-Windows platforms. - Add stdout/stderr redirection to
/dev/nullfor thenohuplaunch path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2139
to
+2143
| # Check if mongod is running on 8.2 or higher | ||
| if int(self.current_version.split('.')[0]) >= 9 or (int(self.current_version.split('.')[0]) == 8 and int(self.current_version.split('.')[1]) >= 2): | ||
| command_str = ("nohup \"%s\" %s --dbpath \"%s\" --logpath \"%s\" " | ||
| "--port %i " | ||
| "%s %s > /dev/null 2>&1 &" % (os.path.join(path, 'mongod'), rs_param, |
Author
There was a problem hiding this comment.
@stennie , do you think we need to add a test case for nohup? From a quick read of test_mlaunch_commandlines.py, it is reading .mlaunch_startup... so it kinda makes sense. I don't think it breaks anything as is though. Any thoughts?
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This change simply swaps the
--forkflag withnohupfor versions of mongod and mongos running on 8.2 and newer to avoid the error below.Testing
Single
Replica Set
Sharded cluster
O/S testing: