Repository navigation
Pin rails to a specific version - #110
Closed
freestylebit wants to merge 4 commits into
Closed
freestylebit wants to merge 4 commits into
freestylebit wants to merge 4 commits into
Conversation
Collaborator
Author
|
We're going to solve this when they release a new version of rails with this fix included. |
johnpaulashenfelter
added
the
rubyforgood
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gemfile points to a branch in rails, which also downloads the history associate with the repository, which can make
bin/setuptake a really long time. Instead, we set this project to a specific version of rails so it only downloads that project so setup can move on to downloading the rest of the dependencies.Additionally...
.tool-versionto assistasdfwith downloading the correct ruby version.brakemanandjsonto the latest versionactionpackthat has a patch of the templated bugfix to not yield incorrect HTML, causing our tests to fail. Hopefully when they merge that patch in the future, we can remove our local vendored copy of the gem.