Sort remaining completion candidates in RegexpCompletor#1230
Open
kryzhovnik wants to merge 1 commit into
Open
Conversation
ruby#379 sorted local variables and string method candidates, but receiver.method completion (the most common case), symbols, global variables and absolute constants were still returned in method table order, which looks random in the completion dialog. Sort them too. Candidates starting with an underscore go last, so that completing `u.` does not begin with __id__, __send__ and other internals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#379 sorted local variables and string method candidates (fixing #349), but
receiver.methodcompletion — the most common case — still returns candidates in method table order, which looks random. Same for symbols, global variables and::constants. With an ActiveRecord model,u.email_addressis listed below all its generated variants:This sorts candidates in
select_message(making the two pre-sorted call sites redundant) and in the symbol/gvar/absolute constant branches.One detail: candidates starting with
_are sorted last, otherwise completingu.would begin with__id__,__send__,_run_commit_callbacksand similar internals instead of regular methods. Same change for TypeCompletor is proposed in ruby/repl_type_completor#78.