Tighten dynamic define_method in callbacks/routing DSL#2708
Merged
Conversation
Danger ReportNo issues found. |
ericproulx
force-pushed
the
refactor/define-method-cleanup
branch
from
f7d3df4 to
52959ef
Compare
ericproulx
force-pushed
the
refactor/define-method-cleanup
branch
2 times, most recently
from
26039f3 to
244cbb9
Compare
- callbacks: replace runtime `pluralize.to_sym` with a precomputed `method_name -> plural_key` mapping so the namespace_stackable key is resolved at load time instead of on every callback definition. - routing: replace `*args` + `args.first || ['/']` with a proper default-arg signature (`path = '/'`), removing the splat allocation and array-of-arrays default. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ericproulx
force-pushed
the
refactor/define-method-cleanup
branch
from
244cbb9 to
05b997c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small refinements to dynamic
define_methodblocks in the DSL:lib/grape/dsl/callbacks.rb— the existing block calledcallback_method.pluralize.to_syminside each generated method, so every invocation ofbefore/after/etc. re-ranpluralizeand allocated a fresh symbol. Replaced with a literal{method_name => plural_key}hash so thenamespace_stackablekey is a constant resolved at load time.lib/grape/dsl/routing.rb— the per-verb method (get,post, …) was defined as|*args, **options, &block|and then computedpaths = args.first || ['/']. Replaced with|path = '/', **options, &block|so the signature reflects the contract (a single path or default'/'), removing the splat allocation and array-of-arrays default. Updated to passpath(singular) toroute, which already accepts both forms.No behaviour change for documented call sites; both methods still accept the same arguments as before.
Test plan
bundle exec rspec🤖 Generated with Claude Code