Repository navigation
Conversation
Collaborator
|
I'm OK with updating this rule, but I'd rather suggest to change the language to something suggesting that both the name and annotated styles are fine. |
pirj
force-pushed
the
change-stlye-of-named-format-token
branch
from
October 5, 2026 21:06
2c950b9 to
58793de
Compare
According to [research](rubocop/rubocop#8827 (comment)): annotated (`%<name>s`): 57497 files inspected, 5785 offenses detected template (`%{name}`): 57497 files inspected, 1279 offenses detected unannotated (`%s`) 57497 files inspected, 6424 offenses detected the `%{name}` is the most commonly used style. The annotated is widely used and acceptable as well.
pirj
force-pushed
the
change-stlye-of-named-format-token
branch
from
October 5, 2026 21:08
58793de to
d7a2e52
Compare
Member
Author
|
Updated. My apologies, I lost track of this for a while. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The guidance inaccurately describes conversion specifiers as encoding a value’s Ruby type.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates Ruby formatting guidance to favor template-style named tokens while retaining annotated tokens for advanced formatting.
Changes:
- Revises
sprintfexamples to use named tokens. - Documents both named-token styles and their use cases.
| File | Description |
|---|---|
README.adoc |
Updates named format-token guidance and examples. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to research:
annotated (
%<name>s):57497 files inspected, 5785 offenses detected
template (
%{name}):57497 files inspected, 1279 offenses detected
unannotated (
%s)57497 files inspected, 6424 offenses detected
the
%{name}is the most commonly used style.Related:
Style/FormatStringTokenrubocop#8827templateinternally rubocop#11349