This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Include ActiveRecord versions above 3.0#42
Open
npafundi wants to merge 1 commit intortomayko:masterfrom
Open
Conversation
In a polymorphic relationship on ActiveRecord 4+, this conditional would result in a `nil` reference class, because it would fall back to the pre-3.0 options rather than using the reflection's `foreign_type`. This change checks for major version 3+ rather than only 3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a polymorphic relationship on ActiveRecord 4+, this conditional would result
in a
nilreference class, because it would fall back to the pre-3.0 optionsrather than using the reflection's
foreign_type.This change checks for major version 3+ rather than only 3.