Repository navigation
Conversation
📊 Automated PR Analysis
SummaryThis PR fixes the Review Checklist
Linked issues: #4418 Analyzed automatically by wshm · This is an automated analysis, not a human review. |
yeahjack
marked this pull request as ready for review
October 5, 2026 16:00
yeahjack
force-pushed
the
fix/go-test-pipe-text
branch
from
October 19, 2026 10:25
28051d2 to
e11a981
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pipe -f go-testJSON filterGoTestEventschema for recognition; leave the Go runner and its JSON result/fuzz/build parsers unchangedCloses #4418. This is the plain-text follow-up to merged #1444 and does not change the list/fuzz routing addressed by #4430 / #4437 / #4438.
Spec-driven re-review
Acceptance was derived from #4418, the repository's lossless fallback principle, and Go's event schema before inspecting this implementation.
plain_failure_after_many_successes_is_preserved_in_full,plain_success_empty_and_non_event_json_are_not_misclassified,mixed_json_and_text_keeps_every_line, and the addedraw_fallback_preserves_line_endings_and_unterminated_text(CRLF, Unicode, whitespace, no trailing newline).output_shaped_json_without_output_is_not_a_test_reportexposed one missed case: an object with Action/Package but no Output lost its diagnostic and becameNo tests found. It failed on the original PR implementation (6 CLI tests passed, 1 failed). A five-line guard now leaves output/build-output records without their required payload unchanged; all 7 CLI tests pass. Matching wrapper unit cases cover the same boundary.valid_json_events_still_use_the_existing_filter, addedpadded_json_and_build_failures_keep_existing_summaries, and existing Go parser tests. The runner, list/fuzz routing, and renderer are unchanged.Package-less
go tool test2jsoninput is conservatively retained raw; Package is optional in that tool's format, so this is a lossless fallback, not a claim that such JSON is malformed. This recognizer checks individual event shapes, not sequence completeness.pipecannot recover the upstream command's status. No plain-text parser or new framework is added.Verification
cargo fmt --all --check,cargo clippy --offline --all-targets, andcargo test --offline --allpassed: 4,122 tests passed; 8 pre-existing ignored tests were not runCI run 37336140553 passed for
fb79b81d570ec3249cc17a66b5a2af0a7baee94f, including Windows/macOS/Linux tests, formatting, clippy, benchmark and security jobs. CLA status passed. The target-branch job is intentionally skipped for the develop base. The optional AI documentation review was skipped because its repository API key is not configured; the job reports success.The spec-driven self-review has no remaining known in-scope finding. Ready for maintainer review.