set sideEffects = false to package.json for webpack treeshaking#681
Open
eaglus wants to merge 1 commit intorrag:masterfrom
Open
set sideEffects = false to package.json for webpack treeshaking#681eaglus wants to merge 1 commit intorrag:masterfrom
eaglus wants to merge 1 commit intorrag:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set sideEffects = false to package.json for webpack treeshaking optimizations: https://webpack.js.org/guides/tree-shaking/
see also https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free
i've checked all code, and i've not found any side effects on modules initialization (access to globals like window/document, css module imports etc).
this means that we can set sideEffects flag to false and have size optimizations in bundles, using react-stockcharts