Skip to content

Open Card Settings in dev artifact exploration - #768

Merged
rowkav09 merged 2 commits into
mainfrom
fix/dev-card-exploration-accordion
Sep 29, 2026
Merged

rowkav09 merged 2 commits into
mainfrom
fix/dev-card-exploration-accordion

Conversation

@rowkav09

Copy link
Copy Markdown
Member

The card-exploration harness waited for #card-form while its Card Settings accordion was closed. After sign-in, wait for the first-run page to detach and the main Configuration heading to show (the same transition used by the packaged Windows WebUI E2E), then open Card Settings before waiting for the form.

Harness-only change; the workflow still downloads and verifies the moving dev ZIP rather than rebuilding source.

Validation: node --check scripts/windows-dev-card-exploration.js, npm run check, npm test (1244 passed, 19 skipped). The PR's Windows workflow must prove the downloaded dev artifact reaches the card/privacy assertions.

@rowkav09

Copy link
Copy Markdown
Member Author

CHANGES REQUESTED at exact head fbaa9f7b2b5916dd8e521b89571eced542cb6200 (a push resets this verdict). The new transition wait and Card Settings expansion match the page structure, but the harness later calls #privacy-hideTitles.check() and #privacy-hideMusic.check() while Privacy Settings is a separate <details class="drpp-accordion"> closed by default in src/settings-page-handler.js. Playwright cannot check a hidden input, so the downloaded-artifact run is likely to stop at the first privacy control before testing redaction/suppression. Open the Privacy Settings accordion before interacting with those inputs and prove the downloaded Windows artifact reaches the final privacy assertions. I checked the script and exact-head page markup, ran script syntax check, npm run check and git diff --check; they pass, but none exercises the Windows browser workflow. No product code changes or merge/push.

@rowkav09

Copy link
Copy Markdown
Member Author

APPROVE the harness change at exact head f1b14fd80353b3af7fa0a37d3891b781b0436741 (a push resets this verdict). The follow-up opens the separate Privacy Settings accordion before checking title/music privacy controls. I checked the first-run-to-Configuration transition, both accordion labels/default closed state, the card form and privacy form markup, plus the exact two-commit patch. Script syntax, npm run check, and git diff --check pass; both commits have rowkav09 author/committer without extra attribution. This is a source-level harness verdict only: I cannot run the Windows downloaded-artifact flow here. Hold merge until that workflow actually reaches and passes the card/privacy assertions, and inspect its screenshots for visual claims. No product-code change or merge/push.

@rowkav09
rowkav09 force-pushed the fix/dev-card-exploration-accordion branch from f1b14fd to 86cb628 Compare September 29, 2026 07:25
@rowkav09

Copy link
Copy Markdown
Member Author

APPROVE the source-level harness change at exact head 86cb6280a41579614d291446d6adde3bc1430a09 (a push resets this verdict). Rebase is clean against current main 2a7bd9f: exactly four added lines in scripts/windows-dev-card-exploration.js, retaining the first-run-to-Configuration wait and opening Card Settings and Privacy Settings before interacting with their forms. I verified both accordion labels and default closed state in the page source, ran the script syntax check, npm run check, and git diff --check; both retained commits have rowkav09 author/committer without extra attribution. This is not a Windows downloaded-artifact or pixel verdict. Keep merge held until that workflow reaches and passes the final card/privacy checks, with screenshot inspection where visual claims matter. No product-code change, merge or push.

@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@rowkav09
rowkav09 merged commit 968b226 into main Sep 29, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant