Repository navigation
fix: reject corrupt stored credentials in the hosted service - #1193
Merged
Merged
Conversation
authenticate, GitHub sign-in, the legacy-token alias path and the card
presence reader each parsed their Redis value with a bare JSON.parse.
One corrupt entry (a bad manual edit, an interrupted write during
failover) crashed every request that touched it with a 500 until the
key was cleared by hand.
- token entries must match one of the two shapes this service writes
(legacy { cardId, deviceId } or signed-in { userId, deviceId });
anything else rejects 401 and can no longer steer ingest's state
keys (np:state:undefined and friends)
- an unreadable or malformed user record fails sign-in with 409
account_needs_repair; the record and the old public handle mapping
are left untouched for manual repair, with no auto-repair and no
old-mapping cleanup. Sign-in rate counters still count the attempt.
- an unreadable card state renders the idle card
- an unreadable legacy token is skipped instead of aliased
11 regression tests cover each entry point.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hosted service's authenticate, GitHub sign-in, legacy-token alias path and card presence reader each parsed their Redis value with a bare JSON.parse. One corrupt entry (a bad manual edit, an interrupted write during failover) crashed every request that touched it with a 500 until the key was cleared by hand.
11 regression tests cover each entry point. They fail without the change and pass with it; the full suite passes 2149 tests with 0 failures and 23 skipped on a clean tree, and the syntax check is clean. They use an in-memory Redis stand-in, not a live Redis.