Repository navigation
fix: drop artwork with an overlong Emby/Jellyfin item ID - #1192
Merged
Merged
Conversation
I bound the artwork item ID at 512 characters, the same limit the image tag already has. An ID at 512 keeps its artwork. A longer ID gives no artwork instead of failing the playing item, so the state and title are kept. Tests cover both Emby and Jellyfin for an ID of 513 characters (artwork dropped, playback and title intact) and for an ID of exactly 512 characters (artwork kept). They use the provider with synthetic items, not a live server. Fixes #1124
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bound the artwork item ID at 512 characters, the same limit the image tag already has. An ID at 512 keeps its artwork. A longer ID gives no artwork instead of failing the playing item, so the state and title are kept.
Tests cover both Emby and Jellyfin for an ID of 513 characters (artwork dropped, playback and title intact) and for an ID of exactly 512 characters (artwork kept). The two 513-character tests fail without the change. They use the provider with synthetic items, not a live server. The full suite passes with 0 failures (23 skipped) and the syntax check is clean.
Fixes #1124