Repository navigation
fix: populate the mediaType template token from the presence kind - #1167
Merged
Merged
Conversation
Providers normalize playback into the presence model's kind field, so
the documented {mediaType} token rendered blank for real playback; only
older callers passing a raw mediaType field got a value. The token now
reads the normalized kind first and keeps the raw field as the fallback.
Fixes #1119
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1119. Providers put the media type in the presence kind field, so the documented {mediaType} token rendered blank for real playback. The token now reads kind first and falls back to the raw mediaType field for older callers. Tests updated, 2 fail without the change.