Repository navigation
fix: bound the artwork upload reply and cancel it on failure - #1166
Merged
Merged
Conversation
The Litterbox reply was buffered in full with response.text() even though it only ever carries one short URL, and a failed upload threw while still owning the unread body. I read the reply through the shared bounded reader with a 64 KB cap and cancel the body on the failure path, without letting cleanup delay or replace the real error. Fixes #1118
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1118. The Litterbox reply was read in full with response.text() though it's one short URL, and a failed upload threw while still holding the unread body. I now read it through the shared bounded reader (64 KB cap) and cancel the body on the failure path, with cleanup errors swallowed so they can't replace the real error. Two new tests fail without the change.