Repository navigation
fix: stop the auto-updater installing twice in one process - #1165
Merged
Merged
Conversation
After a successful install the files on disk are new but the running process is still the old code. A second install-mode check now returns the first install result instead of installing again, so the first rollback backup is kept and a restart is needed before another install.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a successful install the files on disk are new but the process is still running the old code. A second install-mode check now gets the first install result back instead of installing again, so the first rollback backup survives and a restart is needed before another install.
This is API-only today: createAutoUpdater is exported but nothing in the app calls it yet, so no runtime behaviour changes. One new test fails without the change.