Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"scripts": {
"build": "node scripts/build.js",
"check": "node --check src/*.js && node --check src/providers/*.js && node --check hosted/api/*.js && node --check hosted/lib/*.js && node --check test/*.js",
"check": "node scripts/check-syntax.js",
"test": "node --test",
"test:coverage": "node --test --experimental-test-coverage"
},
Expand Down
28 changes: 28 additions & 0 deletions scripts/check-syntax.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import {readdirSync} from 'node:fs';
import {resolve,join} from 'node:path';
import {spawnSync} from 'node:child_process';

// node --check accepts one file, not a shell-expanded list. Check each source
// separately, including nested hosted routes and scripts, without executing it.
const excluded=new Set(['.git','node_modules','dist','coverage','.next']);
function filesAt(dir){
const files=[];
for(const entry of readdirSync(dir,{withFileTypes:true}).sort((a,b)=>a.name.localeCompare(b.name))){
const file=join(dir,entry.name);
if(entry.isDirectory()&&!excluded.has(entry.name))files.push(...filesAt(file));
else if(entry.isFile()&&/\.(?:js|mjs|cjs)$/.test(entry.name))files.push(file);
}
return files;
}
let failed=false;
const files=filesAt(resolve(process.argv[2]??'.'));
for(const file of files){
const result=spawnSync(process.execPath,['--check',file],{encoding:'utf8'});
if(result.error||result.status!==0){
failed=true;
process.stderr.write(`Syntax check failed: ${file}\n`);
process.stderr.write(result.stderr||String(result.error??`exit ${result.status}`)+'\n');
}
}
console.log(`Checked ${files.length} JavaScript file${files.length===1?'':'s'}.`);
process.exitCode=failed?1:0;
27 changes: 27 additions & 0 deletions test/syntax-check.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import {fileURLToPath} from "node:url";
import test from 'node:test';
import assert from 'node:assert/strict';
import {mkdtemp,mkdir,writeFile,rm} from 'node:fs/promises';
import {join} from 'node:path';
import {tmpdir} from 'node:os';
import {spawnSync} from 'node:child_process';
const checker=new URL('../scripts/check-syntax.js',import.meta.url);
test('syntax checker rejects a bad second file, including nested files and spaces',async()=>{
const root=await mkdtemp(join(tmpdir(),'syntax checker '));
try{
await mkdir(join(root,'nested'));
await writeFile(join(root,'a.mjs'),'export const ok = true;');
await writeFile(join(root,'nested','b file.mjs'),'export const broken = ;');
const result=spawnSync(process.execPath,[fileURLToPath(checker),root],{encoding:'utf8'});
assert.equal(result.status,1);assert.match(result.stderr,/b file\.mjs/);assert.match(result.stderr,/SyntaxError/);
}finally{await rm(root,{recursive:true,force:true});}
});
test('syntax checker accepts valid files and does not check dependencies/build output',async()=>{
const root=await mkdtemp(join(tmpdir(),'syntax checker '));
try{
await writeFile(join(root,'a.cjs'),'module.exports = true;');
for(const dir of ['node_modules','.git','dist']){await mkdir(join(root,dir));await writeFile(join(root,dir,'broken.js'),'const = ;');}
const result=spawnSync(process.execPath,[fileURLToPath(checker),root],{encoding:'utf8'});
assert.equal(result.status,0,result.stderr);assert.match(result.stdout,/Checked 1 JavaScript file/);
}finally{await rm(root,{recursive:true,force:true});}
});
Loading