Repository navigation
fix: treat only a refused shutdown request as the app being absent - #1160
Merged
Merged
Conversation
The initial shutdown POST mapped every failure except a timeout to "not-running", so a reset or a broken reply from a live app let setup continue as if nothing were running. Only connection-refused proves absence, the same rule the wait loop already follows; anything else is "unavailable". Fixes #1123
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1123. Only connection-refused counts as absent; resets and broken replies from a live app are reported as unavailable. The new test fails without the change. Fixture-only: no native Windows run.