Repository navigation
Hide the artist when titles are hidden - #1107
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1097 presence carries a separate
artist.applyPrivacyblanked title, subtitle, series, season, episode and year when titles are hidden but leftartist, so the{artist}template field (details/state templates, and the default "{artist} on {service}" status name) showed the artist while titles were meant to be hidden.Fix:
artistis nulled with the other redacted fields.Fail-first: new test in test/privacy.test.js fails before the change. The combined e2e "redacted titles are hidden on both the card and Discord" fails on the Discord name change (#1105) without it.