Repository navigation
Show a frozen hosted session as paused before it is cleared - #1106
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The hosted loop only reacted to a frozen position after stuckAfterMs (300s), so until then every poll uploaded the session as playing at a fixed position and the card kept showing a live track after the player closed without a clean stop. A stallAfterMs window (60s, below stuckAfterMs, same as the Discord loop in #1099) now uploads the item as paused at that position; the 300s idle upload is unchanged and moving playback goes back to playing. Fixes #1100.
rowkav09
force-pushed
the
fix/hosted-stalled-playing
branch
from
October 2, 2026 16:44
919a760 to
f45834a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1100. Mirrors the Discord change in #1104: a stallAfterMs window (default 60s, always below stuckAfterMs) uploads a frozen playing session as paused at its position; the existing idle upload at 300s and the return to playing on movement are unchanged. Two existing hosted-loop expectations that assumed 'playing' while frozen were updated. New test fails without the change; full suite 1568/1568, npm run check ok.