Repository navigation
Wrap long user names in the Status page All servers list - #1084
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1083. The
#serversrows had nooverflow-wrap, so a long unbroken user name widened the whole page. Addedoverflow-wrap:anywherefor them, the same as the other Status text.The new test fails without the rule and passes with it. Full suite passes (1513/1513).
Checked in headless Chrome against the real handler with two servers, the first with a 200-character user name: page scrollWidth was 1494 at 390px without the change and 390 with it (equal to the viewport); at 1200px it is 1185, equal to the viewport. No overlap or layout change otherwise.