Repository navigation
fix(python): don't treat obj.import_module() as a dynamic import - #825
Merged
Merged
Conversation
Require the call name not to follow a dot or an identifier character. Fixes #823.
Allow importlib as a receiver for __import__, as before the receiver check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #823.
The dynamic-import pattern could start after a dot or inside a longer name, so
obj.import_module("requests"),obj.__import__("numpy")andmyimportlib.import_module("scipy")were reported as real dynamic imports. It now requires that the call is not preceded by a dot or an identifier character. The real receivers are still accepted:importlib.import_module, bareimport_module, and__import__bare or viaimportlib/builtins/__builtins__.Tests: the negative cases fail without the change; positives cover the receivers above, including spaces around the dot. Adapter suite passes (257).
Aliased
importlib/import_moduleare a separate, older gap: #824.