Repository navigation
Keep Pipfile shorthand environment markers - #816
Conversation
Shorthand keys such as sys_platform and python_version were allow-listed but never read, so the requirement lost its condition. Build the marker from them and AND it with a full markers string, parenthesising each part so an OR expression keeps its scope.
|
APPROVE at head 0bde370, with two non-blocking notes. origin/main (d25c493) is in the head. For each Pipfile package table the parser now collects the full Notes, neither a blocker. First, the key list adds CI at this head when I looked: CodeFactor, lint, typecheck, image, self-scan, consumer ubuntu x2 and the rest of the jobs succeeded; corpus was still in progress, so not fully CI-green yet. Same-account review. |
Fixes #815.
Pipfile shorthand keys like
sys_platformandpython_versionwere allow-listed but onlymarkerswas read, sopywin32 = {version = "*", sys_platform = "== 'win32'"}lost its condition. The marker is now built from the shorthand keys and ANDed with a fullmarkersstring, with each part parenthesised so an OR expression keeps its scope. Two regressions fail before the change; the Python adapter suite passes after (245), with Prettier and ESLint clean.