fix: Normalize db_repos to short repo names in coverage dashboard - #26
Conversation
rubambiza
added
the
ready-for-ai-review
clawgenti
left a comment
clawgenti
left a comment
There was a problem hiding this comment.
Single-line fix that aligns db_repos normalization with lh_repos and pr_repos — both already apply split("/")[1]. The change is correct: unique operates on full owner/repo paths before the split, and the downstream sort -u handles any residual dedup after normalization. DCO signed, all CI checks pass.
All checks pass. Ready for human review.
Reviewed by clawgenti using github:pr-review
Match lh_repos and pr_repos by applying split("/")[1] to db_repos so
the cross-program coverage table does not emit duplicate rows for a repo
covered by dep-bump plus another program (owner/repo vs repo).
Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com>
Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
dac82e7 to
0cb45d1
Compare
clawgenti
left a comment
clawgenti
left a comment
There was a problem hiding this comment.
Single-line fix that aligns db_repos normalization with lh_repos and pr_repos — both already apply split("/")[1]. The downstream grep -qxF exact-match at line 391 requires short repo names, confirming this fix is correct and necessary. DCO signed, CI passes, no findings.
All checks pass. Ready for human review.
Reviewed by clawgenti using github:pr-review
rubambiza
added
ready-for-human-review
mrsabath
left a comment
mrsabath
left a comment
There was a problem hiding this comment.
LGTM — correct and well-scoped. Adding | split("/")[1] brings db_repos in line with lh_repos (line 355) and pr_repos (line 369), which already normalize to short names. Verified this is more than cosmetic: all_repos merges the three via sort -u and the coverage-table membership checks use grep -qxF (exact full-line match), so a owner/kagenti vs kagenti mismatch both duplicated rows and made the dep-bump membership test miss. The no-slash / empty-string edge case is handled identically to the existing siblings (grep -v '^$'), so no regression. Testing is documented (bash -n, shellcheck, jq sanity).
Areas reviewed: Shell
Commit: 1, signed-off (DCO pass) · CI: green
Verdict: APPROVE
3 participants
Summary
Normalizes
db_reposto short repo names in the automation-health-dashboard, matchinglh_reposandpr_repos. Previouslydb_reposkept the fullowner/repoform while the other two usedsplit("/")[1], which could produce duplicate rows in the cross-program coverage table (e.g.kagentifrom one program vsowner/kagentifrom dep-bump).Testing
bash -npasses.shellcheckclean apart from a pre-existing SC2034 (SCRIPT_DIRunused) unrelated to this change.kagenti/kagentiandbar/kagentinormalize tokagentiand dedupe to a single coverage-table row.Follow-up to the pre-existing nit in #17 (discussion r3515526432).
Fixes #22
Assisted-By: Claude Code