Add some rudimentary testing and run it in GitHub CI#34
Open
dabrahams wants to merge 3 commits intoroop:masterfrom
Open
Add some rudimentary testing and run it in GitHub CI#34dabrahams wants to merge 3 commits intoroop:masterfrom
dabrahams wants to merge 3 commits intoroop:masterfrom
Conversation
Contributor
Author
|
…and Windows support is implemented now. That PR depends on this one, so it's still on my fork, but it will be re-targeted at this repository if this PR is merged. |
Contributor
Author
|
@roop Realistically speaking, is there any chance of my improvements being merged? I don't want to waste time submitting PRs here if you're abandoning this, or if you just don't approve of what I'm doing. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests should exercise the error capture functionality; they currently do not.
Windows support is coming, but expect it to be a much bigger change because of the many workarounds required.