Skip to content

update to phpunit 7 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fnash wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update to phpunit 7 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"require": {},
"require-dev": {
"friendsofphp/php-cs-fixer": "^2.0",
"phpunit/phpunit": "^5.7",
"symfony/var-dumper": "^3.2"
"phpunit/phpunit": "^7.5",
"symfony/var-dumper": "4.3"
},
"scripts": {
"test": "phpunit",
Expand Down
3 changes: 1 addition & 2 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
convertNoticesToExceptions="true"
convertWarningsToExceptions="true"
processIsolation="false"
stopOnFailure="false"
syntaxCheck="false">
stopOnFailure="false">
<testsuites>
<testsuite name="Application Test Suite">
<directory>tests</directory>
Expand Down
4 changes: 2 additions & 2 deletions src/SnapshotAssertions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ trait SnapshotAssertions
*
* @param mixed $expected
* @param string|null $identifier An additional identifier to append to the snapshot ID
* @param string|null $message A message to throw in case of error
* @param string $message A message to throw in case of error
*/
protected function assertEqualsSnapshot($expected, $identifier = null, $message = null)
protected function assertEqualsSnapshot($expected, $identifier = null, $message = '')
{
SnapshotsManager::setSuite($this);
$snapshot = SnapshotsManager::upsertSnapshotContents($identifier, $expected);
Expand Down
4 changes: 2 additions & 2 deletions tests/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

namespace Madewithlove\PhpunitSnapshots;

use PHPUnit_Framework_TestCase;
use PHPUnit\Framework\TestCase as PHPUnitFrameworkTestCase;

abstract class TestCase extends PHPUnit_Framework_TestCase
abstract class TestCase extends PHPUnitFrameworkTestCase
{
use SnapshotAssertions;
}