Fixes saved PTZ presets forcing the tilt coordinate to the upper bound. - #223
Open
bakadave wants to merge 1 commit into
Open
Fixes saved PTZ presets forcing the tilt coordinate to the upper bound.#223bakadave wants to merge 1 commit into
bakadave wants to merge 1 commit into
Conversation
bakadave
marked this pull request as ready for review
August 14, 2026 06:52
Author
|
tested, works well on my camera |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACTION_SET_PRESETclamps the current tilt position withif (y < MAX_Y) y = MAX_Y, which rewrites almost all valid Y positions toMAX_Ybefore saving.go_presetthen sends that saved Y coordinate to the PTZ driver, causing numbered presets to restore pan correctly but drive tilt to the vertical limit.This changes the clamp to
if (y > MAX_Y) y = MAX_Y, matching the existingset_homepath.EDIT: old presets need to be saved again after patch