Fix bug where enums won't transpile in @sgnode tests#237
Draft
TwitchBronBron wants to merge 2 commits intomasterfrom
Draft
Fix bug where enums won't transpile in @sgnode tests#237TwitchBronBron wants to merge 2 commits intomasterfrom
TwitchBronBron wants to merge 2 commits intomasterfrom
Conversation
Collaborator
|
this test passes for me, @TwitchBronBron 🤷 |
Member
Author
|
This exact test passes for you? In slack you pasted a screenshot of a completely different test. your screenshot: my test: |
Collaborator
Why do you have to be difficult and use these dashed facts all the time.!? dash it, man! indeed. I see you are right! (though at least i had the word enum in the screenshot - not entirely off the map) will look into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the transpiler plugin that wasn't transpiling enums in @SGNode tests.
NOTE: this is just the tests. Please, someone, figure out how to fix it!