Skip to content

fix(store/services): respect explicit default in combo field provider resolution#1177

Open
ksaurabhAparavi wants to merge 1 commit into
rocketride-org:developfrom
ksaurabhAparavi:fix/RR-1164-combo-field-default
Open

fix(store/services): respect explicit default in combo field provider resolution#1177
ksaurabhAparavi wants to merge 1 commit into
rocketride-org:developfrom
ksaurabhAparavi:fix/RR-1164-combo-field-default

Conversation

@ksaurabhAparavi

@ksaurabhAparavi ksaurabhAparavi commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Combo-field provider resolution ignored an explicitly configured default.
  • Honor the explicit default during resolution.

Testing

  • CI (./builder test) — relying on GitHub Actions; not runnable in the contributor's local shell (engine build / Maven / torch unavailable). Static checks (compile, no conflict markers) pass.

Linked Issue

Fixes #1164

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The processCombo function in the services module now respects explicit default values from combo field definitions when setting the provider default, falling back to the computed first-provider only when no explicit default is specified.

Changes

Combo provider default selection

Layer / File(s) Summary
Combo provider default respects explicit default
packages/server/engine-lib/engLib/store/services/services.cpp
The provider subfield default selection now reads an optional default from the combo field definition and uses it as the provider default; if absent or empty, it uses the previously computed defaultProvider fallback.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A combo sought its default way,
With explicit hints now here to stay,
No more surprises, just what's defined—
The provider path is clear and kind! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR changes align with issue #1164's objective to honor explicit defaults during combo field provider resolution by modifying the default value assignment logic.
Out of Scope Changes check ✅ Passed The changes are limited to the combo field provider-resolution logic as required, with no unrelated modifications detected in the scope of the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: respecting an explicit default value in combo field provider resolution, which directly addresses the PR's core objective of fixing issue #1164.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID. Do not edit or delete.

@github-actions github-actions Bot added the module:server C++ engine and server components label Jun 8, 2026
@ksaurabhAparavi ksaurabhAparavi force-pushed the fix/RR-1164-combo-field-default branch from 3e58183 to 7d1c34b Compare June 8, 2026 11:51
@ksaurabhAparavi ksaurabhAparavi changed the title ADS-652: respect explicit default in combo field provider resolution (#39) fix(store/services): respect explicit default in combo field provider resolution Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:server C++ engine and server components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combo field provider resolution ignores explicit default

1 participant