Skip to content

Refactor createNetworkStateForNode and createNetworkState#1049

Merged
0xfornax merged 3 commits intomasterfrom
refactor-network-state
Mar 25, 2026
Merged

Refactor createNetworkStateForNode and createNetworkState#1049
0xfornax merged 3 commits intomasterfrom
refactor-network-state

Conversation

@0xfornax
Copy link
Copy Markdown
Member

@0xfornax 0xfornax commented Mar 23, 2026

Closes #1023

@github-actions
Copy link
Copy Markdown

Coverage Report

@0xfornax 0xfornax force-pushed the refactor-network-state branch from ab3078c to d274572 Compare March 23, 2026 19:27
@github-actions
Copy link
Copy Markdown

Coverage Report

@github-actions
Copy link
Copy Markdown

Coverage Report

Co-authored-by: Thomas Pan  <43927782+thomaspanf@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

Coverage Report

@github-actions
Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/shared/services/state 6.82% (+2.50%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/shared/services/state/manager.go 0.00% (ø) 512 0 512
github.com/rocket-pool/smartnode/shared/services/state/network-state.go 7.92% (+3.62%) 2538 (-767) 201 (+59) 2337 (-826) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/rocket-pool/smartnode/shared/services/state/network-state_test.go

@0xfornax 0xfornax merged commit 1abbaca into master Mar 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

state query for single node fetches all megapool details

2 participants