Open
Conversation
... for rnp_generate_key_ex add roundtrip test for PQC certs clang-format
require Botan 3.6.0 for PQC switch to final NIST PQC standards update KMAC Key Combiner
fail gracefully on parsing v6 cleartext sigs
also code formatting
Closed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2355 +/- ##
==========================================
- Coverage 85.46% 85.46% -0.01%
==========================================
Files 126 126
Lines 22713 22731 +18
==========================================
+ Hits 19411 19426 +15
- Misses 3302 3305 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@ni4 3 checks fail due to the Botan version (3.6.0 required now). I suppose the images can easily be changed (or alternatively RFC95080/PQC disabled) in the corresponding yml files. I'm not familiar with your CI/CD setup, therefore I think someone else should do the necessary changes. |
Only compiling PQC support now gives the option to use v4 MLKEM768+X25519 encryption subkeys. Added a v4 ECC + PQC certificate to TUI
This was referenced Oct 29, 2025
25ee951 to
004fefc
Compare
004fefc to
7ab4373
Compare
121d8b8 to
e1af516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates to the newest PQC draft version, and adds/fixes some RFC 9580 functionality. The PR replaces #2287. The PQC draft can be seen as stable now since it has passed Working Group Last Call recently.
The most prominent changes are:
V6 / RFC 9580
PQC
Further Code Changes
PQC code is not independent from Crypto Refresh / RFC9580 any more and thusThis is changed again in newer commits to allow MLKEM768+X25519 for v4 keys without compiling the crypto refresh code.ENABLE_CRYPTO_REFRESHis required forENABLE_PQCENABLE_CRYPTO_REFRESHandENABLE_PQCnow requires Botan 3.6.CRYPTO_REFRESH_ENABLEDis true.@ni4 since I had to rebase a lot and fixed some stuff only at the end of the rebasing, the history is not perfectly intact. Please tell me if you prefer to keep the commits anyway or whether I should squash them into a single commit. I hope I did not mess anything up when rebasing.
As next steps I would like to rebase the other PRs #2296 and #2207 (that is considerably less code than in this PR).