Fixed: Debug mode crashed with im_gui assert if scroll area was moved outside the visible screen area - #4
Open
henrikbuchholz wants to merge 1 commit into
Conversation
When using imgui_console with more recent im_gui versions, we got asserts due to BeginChild/EndChild inconsistencies:
If ImGui::BeginChild("ScrollRegion##"..) returned false, ImGui.EndChild wasn't called (because it was inside the if-block).
This caused an assert in a later End() call:
IM_ASSERT_USER_ERROR(g.WithinEndChild, "Must call EndChild() and not End()!");
Fix: Moving the EndChild() call outside the if-scope (to always call it) fixed the problem.
Note that (at least for more recent imgui versions) always push the child window - no matter whether the function returned true or false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using imgui_console, we sometimes got asserts due to BeginChild/EndChild inconsistencies: If ImGui::BeginChild("ScrollRegion##"..) returned false, ImGui.EndChild wasn't called (because it was inside the if-block).
This caused an assert in a later End() call:
IM_ASSERT_USER_ERROR(g.WithinEndChild, "Must call EndChild() and not End()!");
Fix:
Moving the EndChild() call outside the if-scope (to always call it) fixed the problem. Note that (at least for more recent imgui versions) always push the child window - no matter whether the function returned true or false.