Fix audio inference - Pass --level 0 to audio feature extractor, and improve error handling#17
Open
orangekittysoftware wants to merge 2 commits into
Conversation
Signed-off-by: OrangeKitty Software Dev <orangekittysoftware@gmail.com>
Signed-off-by: OrangeKitty Software Dev <orangekittysoftware@gmail.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the audio inference stage was failing due to a misleading error about Python type mismatches on the 'video' parameter - turned out the .npy file was not being created because the
--level 1default was being interpreted very lierally by the aduo feature extractore script. Passing an explict--level 0resolved the issue.Also added some paranoid error checking around the intermediate file creation during audio inference.