This repository was archived by the owner on Oct 22, 2025. It is now read-only.
fix(cloudflare-workers): always mount registry router#1126
Open
miapolis wants to merge 1 commit intorivet-dev:mainfrom
Open
fix(cloudflare-workers): always mount registry router#1126miapolis wants to merge 1 commit intorivet-dev:mainfrom
miapolis wants to merge 1 commit intorivet-dev:mainfrom
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Collaborator
|
@NathanFlurry looks very good, lets merge it! |
jog1t
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.rivet.gg/docs/hosting-providers/cloudflare-workers
The registry doesn't get mounted if an instance of
Honois passed intocreateHandler.I'm assuming that since the docs don't reference mounting the
/registryroute manually, that it should be included automatically even with a Hono instance defined by the user. Correct me if I'm wrong—this default behavior makes sense to me.